feat: EIP-7742 #12957
Open
feat: EIP-7742 #12957
+366
−147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klkvr
force-pushed
the
klkvr/eip7742
branch
2 times, most recently
from
f08d4cc to
09fbac0
Compare
Merged
klkvr
requested review from
mattsse,
Rjected,
emhane,
fgimenez,
rkrasiuk and
gakonst
as code owners
mattsse
reviewed
Dec 11, 2024
Comment on lines
+336
to
+346
| let expected_excess_blob_gas = if chain_spec.is_prague_active_at_timestamp(parent.timestamp()) { | ||
| let parent_target_blobs_per_block = | ||
| parent.target_blobs_per_block().ok_or(ConsensusError::TargetBlobsPerBlockMissing)?; | ||
| eip7742::calc_excess_blob_gas( | ||
| parent_excess_blob_gas, | ||
| parent_blob_gas_used, | ||
| parent_target_blobs_per_block, | ||
| ) | ||
| } else { | ||
| eip4844::calc_excess_blob_gas(parent_excess_blob_gas, parent_blob_gas_used) | ||
| }; |
onbjerg
approved these changes
Dec 12, 2024
onbjerg
added
the
S-blocked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements EIP-7742
Changes include:
forkchoiceUpdatedV4endpoint and validation for V4-specific fieldstargetBlobsPerBlockfield and correctly calculated excess blob gasfeeHistorykeeps track of target blob count, and accounts for it when computing blob fee for pending block