fix: return bool for set_max_da_size (#13423)

paradigmxyz · Dec 17, 2024 · c51a188 · c51a188
1 parent 1e402fa
commit c51a188
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 23 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/Cargo.toml b/Cargo.toml
@@ -477,11 +477,11 @@ alloy-transport-ipc = { version = "0.8.1", default-features = false }
 alloy-transport-ws = { version = "0.8.1", default-features = false }
 
 # op
-op-alloy-rpc-types = "0.8.3"
-op-alloy-rpc-types-engine = "0.8.3"
-op-alloy-rpc-jsonrpsee = "0.8.3"
-op-alloy-network = "0.8.3"
-op-alloy-consensus = "0.8.3"
+op-alloy-rpc-types = "0.8.4"
+op-alloy-rpc-types-engine = "0.8.4"
+op-alloy-rpc-jsonrpsee = "0.8.4"
+op-alloy-network = "0.8.4"
+op-alloy-consensus = "0.8.4"
 
 # misc
 aquamarine = "0.6"

diff --git a/crates/optimism/rpc/src/miner.rs b/crates/optimism/rpc/src/miner.rs
@@ -24,9 +24,9 @@ impl OpMinerExtApi {
 #[async_trait]
 impl MinerApiExtServer for OpMinerExtApi {
     /// Handler for `miner_setMaxDASize` RPC method.
-    async fn set_max_da_size(&self, max_tx_size: U64, max_block_size: U64) -> RpcResult<()> {
+    async fn set_max_da_size(&self, max_tx_size: U64, max_block_size: U64) -> RpcResult<bool> {
         debug!(target: "rpc", "Setting max DA size: tx={}, block={}", max_tx_size, max_block_size);
         self.da_config.set_max_da_size(max_tx_size.to(), max_block_size.to());
-        Ok(())
+        Ok(true)
     }
 }