Skip to content
Lint

fix(openapiv3-indexmap): support indexmap 2 #1218

Sign in to view logs

fix(openapiv3-indexmap): support indexmap 2

fix(openapiv3-indexmap): support indexmap 2 #1218

This check has been archived and is scheduled for deletion. Learn more about checks retention
GitHub Actions / clippy failed Sep 8, 2023 in 1s

clippy

11 errors

Details

Results

Message level Amount
Internal compiler error 0
Error 11
Warning 0
Note 0
Help 0

Versions

  • rustc 1.74.0-nightly (1e746d774 2023-09-07)
  • cargo 1.74.0-nightly (d14c85f4e 2023-09-05)
  • clippy 0.1.74 (1e746d7 2023-09-07)

Annotations

Check failure on line 74 in plugins/actix-web/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

explicit call to `.into_iter()` in function argument accepting `IntoIterator` 

error: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
  --> plugins/actix-web/src/lib.rs:74:35
   |
74 |             op_map.methods.extend(operations.into_iter());
   |                                   ^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `operations`
   |
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
  --> /rustc/1e746d7741d44551e9378daf13b8797322aa0b74/library/core/src/iter/traits/collect.rs:371:18
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

Check failure on line 73 in plugins/actix-web/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

use of `or_insert_with` to construct default value 

error: use of `or_insert_with` to construct default value
  --> plugins/actix-web/src/lib.rs:73:18
   |
73 |                 .or_insert_with(Default::default);
   |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default

Check failure on line 450 in plugins/actix-web/src/app.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

explicit call to `.into_iter()` in function argument accepting `IntoIterator` 

error: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
   --> plugins/actix-web/src/app.rs:450:32
    |
450 |         api.definitions.extend(factory.definitions().into_iter());
    |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `factory.definitions()`
    |
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
   --> /rustc/1e746d7741d44551e9378daf13b8797322aa0b74/library/core/src/iter/traits/collect.rs:371:18
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

Check failure on line 744 in plugins/actix-web/src/web.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

explicit call to `.into_iter()` in function argument accepting `IntoIterator` 

error: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
   --> plugins/actix-web/src/web.rs:744:33
    |
744 |         self.definitions.extend(factory.definitions().into_iter());
    |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `factory.definitions()`
    |
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
   --> /rustc/1e746d7741d44551e9378daf13b8797322aa0b74/library/core/src/iter/traits/collect.rs:371:18
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

Check failure on line 732 in plugins/actix-web/src/web.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

explicit call to `.into_iter()` in function argument accepting `IntoIterator` 

error: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
   --> plugins/actix-web/src/web.rs:732:33
    |
732 |         self.definitions.extend(w.definitions().into_iter());
    |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `w.definitions()`
    |
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
   --> /rustc/1e746d7741d44551e9378daf13b8797322aa0b74/library/core/src/iter/traits/collect.rs:371:18
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

Check failure on line 722 in plugins/actix-web/src/web.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

use of `or_insert_with` to construct default value 

error: use of `or_insert_with` to construct default value
   --> plugins/actix-web/src/web.rs:722:42
    |
722 |             let op_map = map.entry(path).or_insert_with(Default::default);
    |                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default

Check failure on line 491 in plugins/actix-web/src/web.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

use of `or_insert_with` to construct default value 

error: use of `or_insert_with` to construct default value
   --> plugins/actix-web/src/web.rs:491:42
    |
491 |             let op_map = map.entry(path).or_insert_with(Default::default);
    |                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
    = note: `-D clippy::unwrap-or-default` implied by `-D clippy::all`
    = help: to override `-D clippy::all` add `#[allow(clippy::unwrap_or_default)]`

Check failure on line 447 in plugins/actix-web/src/web.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

explicit call to `.into_iter()` in function argument accepting `IntoIterator` 

error: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
   --> plugins/actix-web/src/web.rs:447:33
    |
447 |         self.definitions.extend(factory.definitions().into_iter());
    |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `factory.definitions()`
    |
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
   --> /rustc/1e746d7741d44551e9378daf13b8797322aa0b74/library/core/src/iter/traits/collect.rs:371:18
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

Check failure on line 251 in plugins/actix-web/src/web.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

explicit call to `.into_iter()` in function argument accepting `IntoIterator` 

error: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
   --> plugins/actix-web/src/web.rs:251:37
    |
251 |             self.definitions.extend(U::definitions().into_iter());
    |                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `U::definitions()`
    |
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
   --> /rustc/1e746d7741d44551e9378daf13b8797322aa0b74/library/core/src/iter/traits/collect.rs:371:18
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

Check failure on line 125 in plugins/actix-web/src/web.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

explicit call to `.into_iter()` in function argument accepting `IntoIterator` 

error: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
   --> plugins/actix-web/src/web.rs:125:33
    |
125 |         self.definitions.extend(w.definitions.into_iter());
    |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `w.definitions`
    |
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
   --> /rustc/1e746d7741d44551e9378daf13b8797322aa0b74/library/core/src/iter/traits/collect.rs:371:18
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

Check failure on line 124 in plugins/actix-web/src/web.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

explicit call to `.into_iter()` in function argument accepting `IntoIterator` 

error: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
   --> plugins/actix-web/src/web.rs:124:32
    |
124 |         self.operations.extend(w.operations.into_iter());
    |                                ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `w.operations`
    |
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
   --> /rustc/1e746d7741d44551e9378daf13b8797322aa0b74/library/core/src/iter/traits/collect.rs:371:18
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
    = note: `-D clippy::useless-conversion` implied by `-D clippy::all`
    = help: to override `-D clippy::all` add `#[allow(clippy::useless_conversion)]`
View more details on GitHub Actions