Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: tests #536

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix: tests #536

wants to merge 2 commits into from

Conversation

RaulTrombin
Copy link
Contributor

The current 'make test' encounters some errors during execution.

The first commit addresses only the clippy warnings.

The second commit, fix: Fix test, extract response on client error, resolves the following error:

error[E0599]: no method named `into_inner` found for associated type `<C as ApiClient>::Response` in the current scope
  --> ./cli.rs:74:49
   |
74 |         Err(ApiError::Failure(_, _, r)) => Ok(r.into_inner()),
   |                                                 ^^^^^^^^^^ method not found in `<C as ApiClient>::Response`

Could someone confirm if this commit is the aproach to resolve the issue?

@@ -31,9 +31,10 @@ static PATH_TEMPLATE_REGEX: Lazy<Regex> =
const SPECIAL_HEADERS: &[&str] = &["content-type", "accept", "authorization"];

/// OpenAPI version.
#[derive(Clone, Copy, Debug, Serialize, Deserialize, Eq, PartialEq)]
#[derive(Clone, Copy, Debug, Default, Serialize, Deserialize, Eq, PartialEq)]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep default as is for now to avoid bumping msrv?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or maybe it's a good time to bump it, though we'd need to have another breaking release but that's ok I guess

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants