Skip to content

Commit

Permalink
ci(actix-2): disable tests
Browse files Browse the repository at this point in the history
chrono 0.4.30 included a breaking change with the Duration:
https://github.com/chronotope/chrono/releases/tag/v0.4.30
This only affects actix2 actix-http 1, so simply disable its
CI for now since it's unlikely anyone is still using it anyways and
we should probably remove support for this in the future.

Signed-off-by: Tiago Castro <[email protected]>
  • Loading branch information
tiagolobocastro committed Sep 8, 2023
1 parent b0ab689 commit 54e5a15
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 13 deletions.
24 changes: 12 additions & 12 deletions .github/workflows/cicd.yml
Original file line number Diff line number Diff line change
Expand Up @@ -70,12 +70,12 @@ jobs:
command: build
args: --all --features "actix3 cli chrono url uuid swagger-ui rapidoc v3 actix3-validator"

- name: Build actix2 features
uses: actions-rs/cargo@v1
timeout-minutes: 10
with:
command: build
args: --all --features "actix2 cli chrono url uuid swagger-ui rapidoc v3"
# - name: Build actix2 features
# uses: actions-rs/cargo@v1
# timeout-minutes: 10
# with:
# command: build
# args: --all --features "actix2 cli chrono url uuid swagger-ui rapidoc v3"

- name: Run actix tests
uses: actions-rs/cargo@v1
Expand All @@ -91,12 +91,12 @@ jobs:
command: test
args: --all --features "actix3 cli chrono url uuid swagger-ui rapidoc v3 actix3-validator"

- name: Run actix2 tests
uses: actions-rs/cargo@v1
timeout-minutes: 20
with:
command: test
args: --all --features "actix2 cli chrono url uuid swagger-ui rapidoc v3"
# - name: Run actix2 tests
# uses: actions-rs/cargo@v1
# timeout-minutes: 20
# with:
# command: test
# args: --all --features "actix2 cli chrono url uuid swagger-ui rapidoc v3"

- name: Install cargo-cache
continue-on-error: true
Expand Down
2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ actix-service1 = { version = "1", package = "actix-service" }
actix-service2 = { version = "2", package = "actix-service" }
actix-web-validator2 = { version = "2.2", package = "actix-web-validator" }
actix-web-validator3 = { version = "3.0", package = "actix-web-validator" }
actix-web2 = { version = "2", default-features = false, package = "actix-web" }
#actix-web2 = { version = "2", default-features = false, package = "actix-web" }
actix-web3 = { version = "3", default-features = false, package = "actix-web" }
actix-web4 = { version = "4", default-features = false, package = "actix-web" }
chrono_dev = { version = "0.4", features = ["serde"], package = "chrono" }
Expand Down

0 comments on commit 54e5a15

Please sign in to comment.