Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lockfile generation for shadowed resolves #21642

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix lockfile generation for shadowed resolves #21642

wants to merge 4 commits into from

Commits on Nov 13, 2024

  1. do not expose resolves for tools not using their default resolve 

    for example, `black` exposes the resolve "black" so that `pants export --resolve=black` works.
 But if `[black].install_from_resolve` is set to "my_resolve",
we shouldn't expose the resolve "black"
    @lilatomic
    lilatomic committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    5312eac View commit details
    Browse the repository at this point in the history

  2. deduplicate identifying matching Python requests 

    the request is selected twice, but they're identical because they select by name.
We can just use a set to deduplicate them
    @lilatomic
    lilatomic committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    3909172 View commit details
    Browse the repository at this point in the history

  3. use deduplicated collection to deduplicate requests 

    A resolve name could be provided by both users and tools,
so it was possible to have the same requested name twice.

This fixes that by deduplicating them in the request.
    @lilatomic
    lilatomic committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    b4603ba View commit details
    Browse the repository at this point in the history

  4. add changelogs

    @lilatomic
    lilatomic committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    e4a5a2b View commit details
    Browse the repository at this point in the history