Turn off the legacy options parser. #21577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Getting a head start on this, but will not merge until we cut the 2.24.x release branch (when I will also add an entry in the 2.25.x release notes). |
benjyw
force-pushed
the
only_use_native_parser
branch
from
30bf90d
to
4d4f6a5
Compare
benjyw
force-pushed
the
only_use_native_parser
branch
3 times, most recently
from
574e3e5
to
6ec85eb
Compare
Only use the native parser from now on. Future changes will strip out the legacy parser's code.
benjyw
force-pushed
the
only_use_native_parser
branch
from
6ec85eb
to
85f6ba2
Compare
benjyw
commented
Nov 12, 2024
| @@ -279,9 +277,7 @@ def verify_configs(self, global_config: Config) -> None: | |||
| section_to_valid_options = {} | |||
| for scope in self.known_scope_to_info: | |||
| section = GLOBAL_SCOPE_CONFIG_SECTION if scope == GLOBAL_SCOPE else scope | |||
| section_to_valid_options[section] = set( | |||
| self.for_scope(scope, check_deprecations=False, log_parser_warnings=True) | |||
There was a problem hiding this comment.
log_parser_warnings was only consumed by the legacy parser.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only use the native parser from now on.
Future changes will strip out the legacy parser's code.