-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: undefined command summary #2614
base: 3.x
Are you sure you want to change the base?
Conversation
I'm a bit confused. I see that It's a new assert.. so I'm not sure how it'd be putting the command summary back, and if an error is happening because the command summary is null, i'm not sure how adding a new assert to the test would prevent that error... |
@kporras07 would probably understand 🙃 |
I'm pretty sure I borked this pushing the wrong branch or something, I don't really recall what the test was supposed to be fore. I was looking at it yesterday because I confused myself. The issue I intended to fix is still present, I'm going to poke at this today. |
97d2947
to
8bc7810
Compare
Re-discovered the process above— I added a test and reverted the fix to see it fail, but I expected phpunit to balk at the PHP notice and it didn't. |
8bc7810
to
fa7e3da
Compare
Unit test I wrote doesn't actually run, removed. |
Fixes undefined notice for
$command_summary
during WP-CLI/Drush executionThis was broken in #2589