BLD/RLS: build wheels with released numpy/cython for Python 3.13 #59819
+5
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisvandenbossche
added
Build
|
(note: we should milestone this as 2.2.3, but the previous PRs adding python 3.13 support have not yet been backported) |
lithomas1
reviewed
Sep 18, 2024
| # and test deps in cibw_before_test.sh after pandas can be built with a released NumPy/Cython | ||
| - python: ["cp313", "3.13"] | ||
| cibw_build_frontend: 'pip; args: --no-build-isolation' | ||
| # after pandas can be built with a released NumPy/Cython | ||
| - python: ["cp313t", "3.13"] | ||
| cibw_build_frontend: 'pip; args: --no-build-isolation' |
There was a problem hiding this comment.
Can the --no-build-isolation here be removed as well?
There was a problem hiding this comment.
We still need cython from main, so I think this is still needed?
Previous PRs are being backported in #59835 |
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
jorisvandenbossche
added a commit
to jorisvandenbossche/pandas
that referenced
this pull request
Sep 18, 2024
…das-dev#59819) (cherry picked from commit 2237217)
|
Backported in #59835 |
lithomas1
added a commit
that referenced
this pull request
Sep 19, 2024
…ly wheels) (#59835) * Bump pypa/cibuildwheel from 2.19.1 to 2.19.2 (#59208) Bumps [pypa/cibuildwheel](https://github.com/pypa/cibuildwheel) from 2.19.1 to 2.19.2. - [Release notes](https://github.com/pypa/cibuildwheel/releases) - [Changelog](https://github.com/pypa/cibuildwheel/blob/main/docs/changelog.md) - [Commits](pypa/cibuildwheel@v2.19.1...v2.19.2) --- updated-dependencies: - dependency-name: pypa/cibuildwheel dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit ad09dc6) * Upload 3.13 & free-threaded nightly wheels (#59136) * Upload free-threaded nightly wheels on Linux and macOS * Consolidate jobs into one * Install build dependencies in before-build and pass --no-build-isolation * Fix {project} placeholder in cibuildwheel config * Correctly quote echo CIBW_BUILD_FRONTEND command * Run echo -e * Add {package} to before-build * Include cibw script in sdist & add matrix value for build frontend * Change manifest and gitattributes * Change gitattributes * Install verioneer in before-build * Add cibw_before_test to install nightly NumPy * Expand before-test to musl * Better comments plus always run before-build/before-test on 3.13 * Add --no-build-isolation in 3.13 as well * Install nightly numpy before windows tests * Address feedback; add todo for NumPy nightly and move default outside matrix * Set build_frontend to 'build' in pyodide build --------- Co-authored-by: Matthew Roeschke <[email protected]> (cherry picked from commit 7c0ee27) * CI: Update to cibuildwheel 2.20.0 (#59401) cibuildwheel 2.20.0 uses the ABI stable Python 3.13.0rc1 and build Python 3.13 wheels by default, which allows removing the `CIBW_PRERELEASE_PYTHONS` flag. Co-authored-by: Matthew Roeschke <[email protected]> (cherry picked from commit 70bb855) * Update wheels.yml * BLD/RLS: build wheels with released numpy/cython for Python 3.13 (#59819) (cherry picked from commit 2237217) * enable prerelease again --------- Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Lysandros Nikolaou <[email protected]> Co-authored-by: Ewout ter Hoeven <[email protected]> Co-authored-by: Thomas Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that there is a released numpy that supports Python 3.13, we can clean up parts of our TODOs related to that (from #59136) in our wheel building workflow.
It was noted in #59817 that our wheel builds were failing because of testing with numpy dev instead of released numpy, a problem which itself is being fixed by #59818