-
-
Notifications
You must be signed in to change notification settings - Fork 18k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upload 3.13 & free-threaded nightly wheels #59136
Merged
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
4371054
Upload free-threaded nightly wheels on Linux and macOS
lysnikolaou 2cb8bbc
Consolidate jobs into one
lysnikolaou 5f54ed7
Install build dependencies in before-build and pass --no-build-isolation
lysnikolaou 8bee350
Fix {project} placeholder in cibuildwheel config
lysnikolaou 0a842b2
Correctly quote echo CIBW_BUILD_FRONTEND command
lysnikolaou c2bbdcb
Run echo -e
lysnikolaou 7e87966
Add {package} to before-build
lysnikolaou c36d905
Include cibw script in sdist & add matrix value for build frontend
lysnikolaou f11120d
Change manifest and gitattributes
lysnikolaou 0b70025
Change gitattributes
lysnikolaou 812527e
Install verioneer in before-build
lysnikolaou e46055a
Add cibw_before_test to install nightly NumPy
lysnikolaou c487998
Expand before-test to musl
lysnikolaou 2258d64
Better comments plus always run before-build/before-test on 3.13
lysnikolaou 0c4753a
Add --no-build-isolation in 3.13 as well
lysnikolaou 15d0c8d
Install nightly numpy before windows tests
lysnikolaou 0cf5c89
Merge branch 'main' into free-threaded-wheels
lysnikolaou edcbf3c
Merge branch 'main' into free-threaded-wheels
lysnikolaou 2397f4c
Address feedback; add todo for NumPy nightly and move default outside…
lysnikolaou 06b6ca1
Merge branch 'main' into free-threaded-wheels
mroeschke 778a60a
Set build_frontend to 'build' in pyodide build
lysnikolaou File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
# TODO: Delete when there's PyPI NumPy/Cython releases the support Python 3.13. | ||
# If free-threading support is not included in those releases, this script will have | ||
# to whether this runs for a free-threaded build instead. | ||
PYTHON_VERSION="$(python -c "import sys; print(f'{sys.version_info.major}{sys.version_info.minor}')")" | ||
if [[ $PYTHON_VERSION == "313" ]]; then | ||
python -m pip install -U pip | ||
python -m pip install -i https://pypi.anaconda.org/scientific-python-nightly-wheels/simple numpy cython | ||
python -m pip install ninja meson-python versioneer[toml] | ||
fi |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
# TODO: Delete when there's PyPI NumPy/Cython releases the support Python 3.13. | ||
# If free-threading support is not included in those releases, this script will have | ||
# to whether this runs for a free-threaded build instead. | ||
PYTHON_VERSION="$(python -c "import sys; print(f'{sys.version_info.major}{sys.version_info.minor}')")" | ||
if [[ $PYTHON_VERSION == "313" ]]; then | ||
python -m pip install -U pip | ||
python -m pip install -i https://pypi.anaconda.org/scientific-python-nightly-wheels/simple numpy | ||
fi |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the wasm build needs to specify
cibw_build_frontend
as something based on the failing buildThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, according to the docs pyodide should ignore this setting, since only "build" is supported.