GH1053 @ for DataFrame, eval in place for DataFrame, test migrations #1054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dr-Irv
requested changes
Nov 25, 2024
pandas-stubs/core/frame.pyi
Outdated
Comment on lines
628
to
631
| @overload | ||
| def eval(self, expr: _str, *, inplace: Literal[False] = ..., **kwargs): ... | ||
| @overload | ||
| def eval(self, expr: _str, *, inplace: Literal[True] = ..., **kwargs) -> None: ... |
There was a problem hiding this comment.
swap these 2 overloads, and with inplace: Literal[True], remove the ellipses.
And for Literal[False] = ..., we should return Scalar | np.ndarray | pd.DataFrame | pd.Series
There was a problem hiding this comment.
I was not totally sure about the returns of the case for False but thanks for adding the details, it is implemented.
For the first point about the order, do you mind clarifying how it changes the results to have them swapped?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__matmul__, typehint pd.DataFrame.evalinplaceand test conversion fortest_frame.py#1053assert_type()to assert the type of any return value