Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove dismiss from wrong network to avoid sending trx to wrong network #10897

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

memoyil
Copy link
Collaborator

@memoyil memoyil commented Oct 30, 2024

To reproduce:

Find a lp position on different chain

Dismiss the wrong network modal

Collect/Add/Remove button available and make transaction when click

(Can happen on other pages too)


PR-Codex overview

This PR primarily focuses on refactoring the code related to network handling in a web application. It simplifies the state management and modifies the way the WrongNetworkModal component is used.

Detailed summary

  • Updated EXCHANGE_PAGE_PATHS to use an array format.
  • Removed the use of useSetAtom for hideWrongNetworkModalAtom.
  • Simplified the CommitButton component's click handling logic.
  • Removed onDismiss prop from WrongNetworkModal.
  • Modified NetworkModal to eliminate unnecessary state management.
  • Removed dismiss handling for the wrong network modal in NetworkModal.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Oct 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 6:47pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
aptos-web ⬜️ Ignored (Inspect) Oct 30, 2024 6:47pm
blog ⬜️ Ignored (Inspect) Visit Preview Oct 30, 2024 6:47pm
bridge ⬜️ Ignored (Inspect) Visit Preview Oct 30, 2024 6:47pm
games ⬜️ Ignored (Inspect) Visit Preview Oct 30, 2024 6:47pm
gamification ⬜️ Ignored (Inspect) Visit Preview Oct 30, 2024 6:47pm
uikit ⬜️ Ignored (Inspect) Visit Preview Oct 30, 2024 6:47pm

Copy link

changeset-bot bot commented Oct 30, 2024

⚠️ No Changeset found

Latest commit: 77b132a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant