-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TypeConversionDict.pop with type #2888
base: main
Are you sure you want to change the base?
Conversation
38d436d
to
3c8cc63
Compare
Typing is slightly messy, but I think correct. mypy certainly seems to be happy with it. I've had to battle a bit with |
@davidism anything else which needs to happen here? (all good if just waiting / no-one gotten to it. just wanna make sure i'm not sitting idle on something i'm supposed to be doing here) |
Since I often use this in a non-werkzeug context, I've extracted the TypeConversionDict into a single-file micro-package: https://github.com/MarcinKonowalczyk/type_conversion_dict. I thought it relevant to post here since i've done quite a bit of test + typing work there. The In that implementation i've also added a |
Proposed implementation of pop with type parameter on
TypeConversionDict
. Address #2883.