Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

follow doc for github default title strategy #141

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

follow doc for github default title strategy #141

wants to merge 1 commit into from

Conversation

clakech
Copy link
Contributor

@clakech clakech commented Jul 29, 2019

No description provided.

@palantirtech
Copy link
Member

Thanks for your interest in palantir/bulldozer, @clakech! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

@bluekeyes
Copy link
Member

Thanks for catching this, @clakech. Since changing the configuration value is technically a breaking change, I'd prefer to update the documentation to match what the code does rather than the other way around.

@clakech
Copy link
Contributor Author

clakech commented Jul 30, 2019

Thanks for catching this, @clakech. Since changing the configuration value is technically a breaking change, I'd prefer to update the documentation to match what the code does rather than the other way around.

I think it is better this way.

If you update the doc according to the doc then your title strategies names will be inconsistent ;)

  • pull_request_title
  • first_commit_title
  • github_default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants