Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent tooltip scroll propagation to parent containers by adding an … #7086

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

JML321
Copy link

@JML321 JML321 commented Nov 20, 2024

Fix for #7057: Duplicated Scrolling Behavior from a Popover in Table2

Issue Description:
When scrolling over a popover from a Table2 Cell component, the table can scroll as well. This occurs because the scroll event from the popover is propagating to the parent table element.

Reproduction & Verification:

Created two sandboxes to demonstrate both the issue and insight into a solution:

  • Custom Sandbox1 (modified from issue 5469): Link
  • Custom Sandbox2 (TruncatedFormat and JSONFormat example): Link

The first sandbox demonstrates the issue without using TruncatedFormat and JSONFormat. The second sandbox demonstrates the issue with TruncatedFormat and JSONFormat.

Adding an onWheel handler using a div tag to the Cell component solves the issue. For both sandboxes, there is an onWheel handler and div tag commented out for each Cell component. By uncommenting the onWheel handler and div tag, the scrolling issue is resolved.

Proposed Solution:

Added an onWheel event handler to the Cell component implementation with a stopPropogation call. This solution worked on my local machine.

Reviewers:

Please check if this change resolves the scrolling issue in your environment.

@changelog-app
Copy link

changelog-app bot commented Nov 20, 2024

Generate changelog in packages/table/changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Prevent tooltip scroll propagation to parent containers by adding an …

Check the box to generate changelog(s)

  • Generate changelog entry

@ashleighp13 ashleighp13 requested a review from jscheiny December 2, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant