Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MoreDrills Completed #76

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -20,3 +20,9 @@ PLATFORMS

DEPENDENCIES
rspec (~> 3.0.0.beta2)

RUBY VERSION
ruby 2.0.0p648

BUNDLED WITH
1.15.1
14 changes: 10 additions & 4 deletions lib/deaf_grandma.rb
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
class DeafGrandma

def initialize
@bye_counter = 0
@bye_counter = 0
end

def run!
Expand All @@ -19,9 +19,15 @@ def run!


def speak(input)

#Implement your code here <<<<<<<<<

counter = 0
if input == input.downcase
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need for explicit returns here.

return "SPEAK UP SONNY!"
elsif input == input.upcase && input != "BYE"
return "NOT SINCE 1964!"
elsif input == input.upcase && input == "BYE"
return "SEE YOU LATER SONNY!"
exit

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this exit line ever run? It seems like it wouldn't be since you return on the line right before

end
end

private
Expand Down
11 changes: 9 additions & 2 deletions lib/fizzbuzz.rb
Original file line number Diff line number Diff line change
@@ -1,8 +1,15 @@
class SuperFizzBuzz

def run(input)

#Implement your code here
if input % 3 == 0 && input % 5 == 0
return "FizzBuzz"
elsif input % 5 == 0
return "Buzz"
elsif input % 3 == 0
return "Fizz"
else
return input
end

end

Expand Down
8 changes: 4 additions & 4 deletions spec/deaf_grandma_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,14 @@
let(:script) { DeafGrandma.new }

it "says 'SPEAK UP SONNY!' when we speak regularly" do
expect(script.speak("Hi Grandma")).to eq "SPEAK UP SONNY!"
expect(script.speak("hi grandma")).to eq "SPEAK UP SONNY!"
end

it "says 'NOT SINCE 1964!' when we yell" do
#implement your test here
expect(script.speak("YELL")).to eq "NOT SINCE 1964!"
end

it "EXTRA CREDIT: How would you test yelling BYE?" do
#implement your test here
expect(script.speak("BYE")).to eq "SEE YOU LATER SONNY!"
end
end
10 changes: 5 additions & 5 deletions spec/fizzbuzz_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -7,16 +7,16 @@
it "returns 'Fizz' when my input is divisible by 3" do
expect(script.run(3)).to eq "Fizz"
end

it "returns 'Buzz' when my input is divisible by 5" do
#implement your test here
expect(script.run(5)).to eq "Buzz"
end

it "returns 'FizzBuzz' when input is divisible by 3 & 5" do
#implement your test here
expect(script.run(15)).to eq "FizzBuzz"
end

it "returns the input number when input isn't divisible by 3, 5, or both" do
#implement your test here
expect(script.run(1)).to eq 1
end
end