[UI/UX] Refactor and enable seasonal splash messages #5009
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes the user will see?
Why am I making these changes?
What are the changes from a developer perspective?
splash-messages.ts
, i18next is used to get all the splash texts for the user's language at once as a json object. Then, all the keys that exist in the "common" category are put in a list, and then if the time matches with a season, all the keys found in that season are pushed to the list. THIS REQUIRES THE LATEST CHANGES FROM THE LOCALE REPO. This way, the game will only choose splash texts that are defined in the language.data/splash_messages
test to reflect these changesScreenshots/Videos
How to test the changes?
Checklist
beta
as my base branchnpm run test
)npm run create-test
) or updated existing tests related to the PR's changes?Are there any localization additions or changes? If so: