[Misc] Catching Charm added to Rival 1 during Events #5001
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damocleas
added
Enhancement
damocleas
requested review from
CodeTappert,
KimJeongSun and
xsn34kzx
and removed request for
CodeTappert and
KimJeongSun
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes the user will see?
During any event, Rival 1 now also gives you a Catching charm
Why am I making these changes?
Thought it would be nice, not too game changing, and it is only for events
What are the changes from a developer perspective?
One extra item handed out from Rival 1 under the event only modifier
How to test the changes?
Add the same data on a local, turn event data on
Checklist
betaas my base branchnpm run test)