Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Balance] Check previous level moves for redundancy when spawning TMs #4996

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

Fontbane
Copy link
Contributor

What are the changes the user will see?

  • TMs won't spawn for mons that can learn the move with a memory mushroom

Why am I making these changes?

  • Reduces redundancy in TM spawns
  • Makes TMs more satisfying to find if they're not just giving you Disarming Voice that you learn at level 6 anyway

What are the changes from a developer perspective?

  • Checks learnable level moves of party members in TmModifierTypeGenerator

Screenshots/Videos

Before: Level 100 Fuecoco gets TM Snarl, despite learning it at level 21
Screenshot_990
After (same wave seed): Level 100 Fuecoco gets different TMs offered
Screenshot_989

How to test the changes?

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I tested the changes manually?
  • Are all unit tests still passing? (npm run test)
    • Have I created new automated tests (npm run create-test) or updated existing tests related to the PR's changes?
  • Have I provided screenshots/videos of the changes (if applicable)?
    • Have I made sure that any UI change works for both UI themes (default and legacy)?

Are there any localization additions or changes? If so:

  • Has a locales PR been created on the locales repo?
    • If so, please leave a link to it here:
  • Has the translation team been contacted for proofreading/translation?

@Fontbane Fontbane requested a review from a team as a code owner December 16, 2024 16:50
@damocleas damocleas added Game Balance Changes focused on game balance Balance Team Specifically a balance team change labels Dec 16, 2024
@DayKev DayKev merged commit 1953e8d into pagefaultgames:beta Dec 20, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Team Specifically a balance team change Game Balance Changes focused on game balance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants