Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QOL] Login now shows "beta" when playing on beta #4973

Merged
merged 2 commits into from
Dec 7, 2024

Conversation

CodeTappert
Copy link
Collaborator

@CodeTappert CodeTappert commented Dec 5, 2024

What are the changes the user will see?

On Beta it will show "Beta" next to "Login" on the login screen
See local PR here:

Why am I making these changes?

Sangara asked me to. Probably to know easier if screenshots of login pages are from beta or not

What are the changes from a developer perspective?

we create a new local key and all it based on the the server URL

Screenshots/Videos

TBD (need locales still)

How to test the changes?

???

  • Play local, should not be there
  • Should be there once its on beta. (you could try to change the code to your own server url to see if it appears i guess)

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I tested the changes manually?
  • Are all unit tests still passing? (npm run test)
    • Have I created new automated tests (npm run create-test) or updated existing tests related to the PR's changes?
  • Have I provided screenshots/videos of the changes (if applicable)?
    • Have I made sure that any UI change works for both UI themes (default and legacy)?

Are there any localization additions or changes? If so:

  • Has a locales PR been created on the locales repo?
    • If so, please leave a link to it here:
  • Has the translation team been contacted for proofreading/translation?

Copy link
Contributor

@SangaraSorama SangaraSorama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Locales PR is merged

@DayKev DayKev merged commit 22f4e74 into pagefaultgames:beta Dec 7, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants