feat: add provider pacts by branch endpoints #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"pb:latest-provider-pacts-with-branch": {
"href": "http://localhost:9292/pacts/provider/{provider}/latest/branch/{branch}",
"title": "Latest pacts for provider with the specified branch",
"templated": true
},
"pb:provider-pacts-with-branch": {
"href": "http://localhost:9292/pacts/provider/{provider}/branch/{branch}",
"title": "All pact versions for the provider with the specified consumer version branch",
"templated": true
},
YOU54F
added a commit
to pactflow/swagger-mock-validator
that referenced
this pull request
Oct 4, 2024
uses latest-provider-pacts-with-branch relies on pact-foundation/pact_broker#728
YOU54F
added a commit
to pactflow/swagger-mock-validator
that referenced
this pull request
Oct 4, 2024
uses latest-provider-pacts-with-branch relies on pact-foundation/pact_broker#728
pahnin
reviewed
Oct 7, 2024
lib/pact_broker/pacts/service.rb
Outdated
| @@ -95,6 +95,10 @@ def find_latest_pacts_for_provider provider_name, options = {} | |||
| pact_repository.find_latest_pacts_for_provider provider_name, options[:tag] | |||
| end | |||
|
|
|||
| def find_latest_pacts_for_provider_for_branch provider_name, options = {} | |||
| pact_repository.find_latest_pacts_for_provider provider_name, options[:branch] | |||
There was a problem hiding this comment.
I think this uses
I am not super well versed with the queries so correct me if I am wrong, but I think this is old way of querying?
https://docs.pact.io/blog/2021/07/04/why-we-are-getting-rid-of-tags
instead should we try to use logic based on the below method ?
There was a problem hiding this comment.
ahh very good spot, appreciate the cookie trail!
# Branch pact versions
Allowed methods: `GET`
Path: `/pacts/provider/{provider}/consumer/{consumer}/branch/{branch}`
Lists all the pact versions with the specified consumer, provider and consumer version branch.
# Latest Branch pact versions
Allowed methods: `GET`
Path: `/pacts/provider/{provider}/consumer/{consumer}/branch/{branch}/latest`
Returns the latest pact version with the specified consumer, provider and consumer version branch.
YOU54F
force-pushed
the
feat/fetch_pacts_by_branch
branch
from
77826d3
to
35ba4d5
Compare
|
needs a few tests writing and hopefully good to go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #619
Provides the following GET routes
/pacts/provider/{provider}/branch//pacts/provider/{provider}/branch/latest/pacts/provider/{provider}/branch/{branch}/pacts/provider/{provider}/branch/{branch}/latest/pacts/provider/{provider}/consumer/{consumer}/branch/pacts/provider/{provider}/consumer/{consumer}/branch/latest/pacts/provider/{provider}/consumer/{consumer}/branch/{branch}/pacts/provider/{provider}/consumer/{consumer}/branch/{branch}/latest