chore: rewrite test workflow #1324
Draft
+8,507
−21,472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JP-Ellis
force-pushed
the
chore/rewrite-test-workflow
branch
2 times, most recently
from
0e13e04 to
58a0949
Compare
JP-Ellis
force-pushed
the
chore/rewrite-test-workflow
branch
8 times, most recently
from
0d3e8a1 to
f118eff
Compare
The motivation for this is improve the speed at which the CI tasks complete in the Pact-JS repository. This hopefully achieves this by having more parallel builds which are each smaller and cached. I have also reduced the reliance on the scripts as it appeared to me that they duplicate a number of steps. These duplications are justified when running locally to ensure all previous steps are run, but in CI it likely results in longer runs thhan necessary. Signed-off-by: JP-Ellis <[email protected]>
Signed-off-by: JP-Ellis <[email protected]>
Also move `devDependencies` into `dependencies` for examples. Signed-off-by: JP-Ellis <[email protected]>
Signed-off-by: JP-Ellis <[email protected]>
Some of the recent updates have broken `ts-node`, but using `tsx` works fine. Signed-off-by: JP-Ellis <[email protected]>
JP-Ellis
force-pushed
the
chore/rewrite-test-workflow
branch
5 times, most recently
from
772f3af to
b532f34
Compare
Instead of relying on `bash` (which may not be installed, such as in alpine images), use POSIX bash. Signed-off-by: JP-Ellis <[email protected]>
JP-Ellis
force-pushed
the
chore/rewrite-test-workflow
branch
from
b532f34 to
b56f39a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation for this is improve the speed at which the CI tasks complete in the Pact-JS repository. This hopefully achieves this by having more parallel builds which are each smaller and cached.
I have also reduced the reliance on the scripts (and the use of
pre) as it appeared to me that they duplicate a number of steps. These duplications are justified when running locally to ensure all previous steps are run, but in CI it likely results in longer runs than necessary.Ideally, I would like to reduce the reliance on the bash scripts, and make better use of the npm scripts section; with the bash scripts being used only when absolutely necessary.