Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upd(tenacity-git): 1.3.1 -> 1.3.3 #6732

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Conversation

Xdavius
Copy link
Contributor

@Xdavius Xdavius commented Dec 7, 2024

No description provided.

@github-actions github-actions bot added the Update Pacscript Updates to the pacscript itself label Dec 7, 2024
@Xdavius
Copy link
Contributor Author

Xdavius commented Dec 7, 2024

PR OK for me, Testing fail but it's fine like this.

Copy link
Member

@Elsie19 Elsie19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't what "fix" is for.

@Xdavius
Copy link
Contributor Author

Xdavius commented Dec 8, 2024

This isn't what "fix" is for.

I don't understand.

The script was broken. I have fixed it.
The build process wasn't good. Was not working on new ubuntu versions.

I also incremented the version to fit the new revision.

Maybe need a better title ?

Sorry, really I don't understand what you want :)

@Elsie19
Copy link
Member

Elsie19 commented Dec 11, 2024

Any package update can include fixes and don't have to be labeled as a fix. So you should change the title to an upd one.

packages/tenacity-git/tenacity-git.pacscript Outdated Show resolved Hide resolved
packages/tenacity-git/tenacity-git.pacscript Outdated Show resolved Hide resolved
packages/tenacity-git/tenacity-git.pacscript Outdated Show resolved Hide resolved
packages/tenacity-git/tenacity-git.pacscript Outdated Show resolved Hide resolved
@Xdavius Xdavius changed the title fix(tenacity-git): upd pacscript to new version upd(tenacity-git): 1.3.1 -> 1.3.1 Dec 17, 2024
@Xdavius Xdavius changed the title upd(tenacity-git): 1.3.1 -> 1.3.1 upd(tenacity-git): 1.3.1 -> 1.3.3 Dec 17, 2024
@Xdavius Xdavius requested a review from Elsie19 December 17, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Update Pacscript Updates to the pacscript itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants