Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(it87-dkms-git): fixed post_upgrade script #6580

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

Xdavius
Copy link
Contributor

@Xdavius Xdavius commented Oct 22, 2024

No description provided.

@github-actions github-actions bot added the Update Pacscript Updates to the pacscript itself label Oct 22, 2024
@Xdavius
Copy link
Contributor Author

Xdavius commented Oct 22, 2024

davius@distrobox-davius-debian ~/CLONES/pacstall-programs $ git commit -m "fix post upgrade"
[INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks.
An error has occurred: InvalidManifestError: 
==> File /home/davius/DISTROBOX/home_stable/.cache/pre-commit/repoaj0ttxut/.pre-commit-hooks.yaml
==> At Hook(id='check-added-large-files')
==> At key: stages
==> At index 0
=====> Expected one of commit, commit-msg, manual, merge-commit, post-checkout, post-commit, post-merge, post-rewrite, prepare-commit-msg, push but got: 'pre-commit'
Check the log at /home/davius/DISTROBOX/home_stable/.cache/pre-commit/pre-commit.log

used the script to gen srcinfo.

Copy link
Member

@Elsie19 Elsie19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like how post_upgrade just calls post_install. Is there any other way to do this?

@Elsie19 Elsie19 added the blocked Unable to be merged due to some issue label Nov 22, 2024
@Xdavius
Copy link
Contributor Author

Xdavius commented Nov 28, 2024

I don't like how post_upgrade just calls post_install. Is there any other way to do this?

This the way on Arch AUR.

I'm not sure if I need to pre_upgrade to remove the old dkms.

It's a driver I use. I have also upgraded it flawlessly.

The previous version doesn't upgrade. Was working on previous pacstall version (because upgrade was uninstall then reinstall)

I can also duplicate the code, use a separate Initramfs function...

Idea's are accepted.

@Elsie19 Elsie19 requested a review from oklopfer December 8, 2024 04:00
@Xdavius Xdavius requested a review from Elsie19 December 17, 2024 16:01
@Xdavius
Copy link
Contributor Author

Xdavius commented Dec 22, 2024

Verified control file and variables. Good to go. Tested OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Unable to be merged due to some issue Update Pacscript Updates to the pacscript itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants