Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor #300

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Refactor #300

wants to merge 7 commits into from

Conversation

mayank1513
Copy link

  • Refactored for readability and best practices.
  • Reduced build size of minified bundle → Might not have much impact on the min-zip size.

- should not be used before defined
- Make it clear without getting into temporal vs spatial dead zone
- don't worry it will be minified by the package builder - tsbuild
- smaller build size
- avoid magic numbers and typos
Copy link

vercel bot commented Jun 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
next-themes-basic ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 15, 2024 7:30am
next-themes-tailwind ❌ Failed (Inspect) Jun 15, 2024 7:30am
next-themes-with-app-dir ❌ Failed (Inspect) Jun 15, 2024 7:30am

@mayank1513
Copy link
Author

Please update the deployment config - set node version to 20

@mayank1513
Copy link
Author

Should I bump turborepo version by applying codemode?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant