Skip to content

Commit

Permalink
Adjust markdown content for scans reporting (#2482)
Browse files Browse the repository at this point in the history
Adjust markdown content for scans reporting

TODO:

 link the discussion

Reviewed-by: Kamil Dudka <[email protected]>
Reviewed-by: Siteshwar Vashisht
Reviewed-by: Maja Massarini
  • Loading branch information
2 parents 54858a7 + ab99505 commit d8f9317
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 4 deletions.
4 changes: 3 additions & 1 deletion packit_service/worker/handlers/copr.py
Original file line number Diff line number Diff line change
Expand Up @@ -584,7 +584,9 @@ def handle_scan(self):
check_names=["osh-diff-scan:fedora-rawhide-x86_64"],
markdown_content=(
"This is an experimental feature. Once the scan finishes, you can see the "
"newly introduced defects in the `added.html` in `Logs`. "
"new findings in the `added.html` in `Logs`. \n\n"
":warning: You can see the list of known issues and also provide your feedback"
" [here](https://github.com/packit/packit/discussions/2371). \n\n"
"You can disable the scanning in your configuration by "
"setting `osh_diff_scan_after_copr_build` to `false`. For more information, "
f"see [docs]({DOCS_URL}/configuration#osh_diff_scan_after_copr_build)."
Expand Down
2 changes: 1 addition & 1 deletion packit_service/worker/reporting/reporters/github.py
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ def set_status(
summary = (
self._create_table(url, links_to_external_services)
+ markdown_content
+ "\n"
+ "\n\n"
+ f"---\n*{News.get_sentence()}*"
)

Expand Down
4 changes: 2 additions & 2 deletions tests/unit/test_reporting.py
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ def test_set_status_github_check(
status=check_status,
conclusion=check_conclusion,
output=create_github_check_run_output(
title, summary + "\n---\n*Interesting news.*"
title, summary + "\n\n---\n*Interesting news.*"
),
).once()

Expand Down Expand Up @@ -460,7 +460,7 @@ def test_status_instead_check(
status=check_status,
conclusion=check_conclusion,
output=create_github_check_run_output(
title, summary + "\n---\n*Interesting news.*"
title, summary + "\n\n---\n*Interesting news.*"
),
).and_raise(exception_type).once()

Expand Down

0 comments on commit d8f9317

Please sign in to comment.