Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change pagination from inifinite loading to paged pagination #500

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Venefilyn
Copy link
Collaborator

@Venefilyn Venefilyn commented Dec 4, 2024

This now has a context that each component under the provider can use.
With this we reduce the code we need to write to handle state handling
between components.

Infinite pagination has been replaced with per-page pagination which
should suit people better than infinitely loading.

Before
image

After
image

TODO:

  • Decide if we want this pagination
  • Migrate other components
  • Remove the end of pagination handling due to bug (insert issue link here)

RELEASE NOTES BEGIN
Change pagination from infinite loading to paged pagination.
RELEASE NOTES END

This now has a context that each component under the provider can use.
With this we reduce the code we need to write to handle state handling
between components.

Infinite pagination has been replaced with per-page pagination which
should suit people better than infinitely loading.

feat: proper pagination
@Venefilyn Venefilyn marked this pull request as draft December 4, 2024 17:17
@usercont-release-bot
Copy link

Preview: https://packit-dashboard-pr-500.surge.sh (deployed at Wed 04 Dec 2024, 17:18 UTC)

Copy link
Contributor

@lbarcziova
Copy link
Member

packit/packit-service#2505 might affect this.

@lbarcziova
Copy link
Member

Once packit/packit-service#2645 is implemented, this should be changed adjusting to that, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants