Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing states to status labels #463

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Conversation

kapr200
Copy link
Contributor

@kapr200 kapr200 commented Oct 1, 2024

New colors and icons for:

  • running
  • pending
  • skipped

Fixes #460

TODO:

  • Write new tests or update the old ones to cover new functionality.
  • Update doc-strings where appropriate.
  • Update or write new documentation in packit/packit.dev.
  • ‹fill in›

Fixes

Related to

Merge before/after

RELEASE NOTES BEGIN

Previously the pending status had same color and icon as skipped status.

Now we added the icons and colors for those two statuses, that are different from each other, and this had changed also for the running state.

RELEASE NOTES END

New colors and icons for:
* running
* pending
* skipped

Fixes packit#460
Copy link
Contributor

Copy link
Collaborator

@Venefilyn Venefilyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

LGTM! Thanks!

@Venefilyn Venefilyn added this pull request to the merge queue Oct 1, 2024
Merged via the queue into packit:main with commit e989730 Oct 1, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use pending icon for pending states
2 participants