chore: bump the deps #462
Merged
chore: bump the deps #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build succeeded. ✔️ pre-commit SUCCESS in 2m 29s |
|
Build succeeded. ✔️ pre-commit SUCCESS in 2m 30s |
Venefilyn
approved these changes
Oct 1, 2024
.github/workflows/preview-pr.yml
Outdated
Comment on lines
45
to
47
| with: | ||
| version: 9 | ||
|
|
There was a problem hiding this comment.
Since we do install ourselves later on we can skip it here. Opened a PR #464 without realizing this tackled this too
Suggested change
| with: | |
| version: 9 | |
| with: | |
| version: 9 | |
| run_install: false |
There was a problem hiding this comment.
But I also had a look at the docs, and it looks like run_install defaults to null which is same as false 👀
Bump the dependencies as the broken page is caused by the change in the default behavior that's been fixed in the @patternfly/react-charts just 2 weeks ago. Fixes packit#461 Signed-off-by: Matej Focko <[email protected]>
mfocko
force-pushed
the
fix/broken-usage-page
branch
from
882baea
to
171409d
Compare
|
Build succeeded. ✔️ pre-commit SUCCESS in 2m 10s |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump the dependencies as the broken usage page is caused by the change in the default behavior that's been fixed in the @patternfly/react-charts just 2 weeks ago.
Fixes #461