fix: Always show build log link for SRPM #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview: https://packit-dashboard-pr-440.surge.sh (deployed at Mon 19 Aug 2024, 14:52 UTC) |
1 task
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 41s |
lbarcziova
reviewed
Aug 19, 2024
This makes the build log always visible as if it returns from packit. Otherwise users would not get any logs when an SRPM build has failed, meaning they would have to chase it down through the link Takes up on results from packit#371
Venefilyn
force-pushed
the
fix/always-show-srpm-logs
branch
from
fc8e954
to
efb1eef
Compare
Done! |
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 42s |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the build log always visible as it will always return from
packit. Otherwise users would not get any logs when an SRPM build has
failed, meaning they would have to chase it down through the link
Takes up on results from #371
TODO:
packit/packit.dev.Fixes
Related to
Merge before/after
RELEASE NOTES BEGIN
Always show SRPM Build logs
RELEASE NOTES END