Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove Prettier from pre-commit config #418

Closed

Conversation

Venefilyn
Copy link
Collaborator

Pre-commit prettier is not maintained anymore and if we want to run it
we should consider an alternative way

https://github.com/pre-commit/mirrors-prettier

RELEASE NOTES BEGIN
Remove Prettier from pre-commit
RELEASE NOTES END

Pre-commit prettier is not maintained anymore and if we want to run it
we should consider an alternative way

https://github.com/pre-commit/mirrors-prettier
@usercont-release-bot
Copy link

usercont-release-bot commented Jun 10, 2024

Preview: https://packit-dashboard-pr-418.surge.sh (deployed at Mon 10 Jun 2024, 14:00 UTC)

Copy link
Contributor

@Venefilyn Venefilyn closed this Jun 10, 2024
@Venefilyn Venefilyn reopened this Jun 10, 2024
Copy link
Contributor

Copy link
Member

@lbarcziova lbarcziova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for noticing and opening the PR! We are using it across multiple other packit repositories, so we should consider using some other fork or some alternative

@Venefilyn
Copy link
Collaborator Author

thanks for noticing and opening the PR! We are using it across multiple other packit repositories, so we should consider using some other fork or some alternative

@lbarcziova could be solved by dprint #419. They don't have pre-commit but they have a GH action

@Venefilyn
Copy link
Collaborator Author

Okay Biome is more popular and has a bit better maintainability for now. I'd vote in favor of that. In #447 currently I run into an issue again with prettier wanting to format a file and we can't fix it easily using pre-commit. I'd rather go to using husky or just a GitHub action for handling formatting using something like Biome

Where else is prettier used atm in other projects? It should only be a JS formatter @lbarcziova

@lbarcziova
Copy link
Member

lbarcziova commented Sep 3, 2024

@Venefilyn we use prettier in other projects to format Markdown, yaml and JSON (e.g. test response files).

Biome looks cool as a JS formatter, if I checked correctly it doesn't support yaml and Markdown, right?

@Venefilyn
Copy link
Collaborator Author

@Venefilyn we use prettier in other projects to format Markdown, yaml and JSON (e.g. test response files).

Biome looks cool as a JS formatter, if I checked correctly it doesn't support yaml and Markdown, right?

@lbarcziova you're right, currently it doesn't support it https://biomejs.dev/internals/language-support/

@Venefilyn Venefilyn closed this Sep 4, 2024
@Venefilyn Venefilyn deleted the chore/remove-prettier-precommit branch September 4, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants