Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate architecture SVG via API #304

Conversation

lachmanfrantisek
Copy link
Member

This is to be able to generate an SVG file with architecture with the URLs using actual, deployed git hashes.

@usercont-release-bot
Copy link

usercont-release-bot commented Jun 22, 2023

Preview: https://packit-dashboard-pr-304.surge.sh (deployed at Fri 30 Jun 2023, 15:16 UTC)

@softwarefactory-project-zuul
Copy link
Contributor

Signed-off-by: Frantisek Lachman <[email protected]>
Signed-off-by: Frantisek Lachman <[email protected]>
@lachmanfrantisek lachmanfrantisek force-pushed the generate-architecture-svg-via-api branch from 1b163d1 to db444a1 Compare June 30, 2023 15:15
@softwarefactory-project-zuul
Copy link
Contributor

Copy link
Member

@mfocko mfocko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the worker v. service remark, LGTM

def architecture_diagram():
system_info = make_response(f"{API_URL}/system").json
system_info["packit_dashboard"] = dict(commit=os.environ.get("VITE_GIT_SHA"))
system_info["packit_worker"] = system_info["packit_service"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure about this? 🤔 I don't think they're the same

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've discussed this locally. Currently, service and workers share repo and are built together so it's fine to expect this.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://softwarefactory-project.io/zuul/t/packit-service/buildset/bbc56a613c704eefbed807985775da9a

✔️ pre-commit SUCCESS in 1m 43s

@softwarefactory-project-zuul
Copy link
Contributor

Pull request merge failed: Merge commits are not allowed on this repository.

@lachmanfrantisek lachmanfrantisek added this pull request to the merge queue Jun 30, 2023
Merged via the queue into packit:main with commit f660d97 Jun 30, 2023
1 check passed
@lachmanfrantisek lachmanfrantisek deleted the generate-architecture-svg-via-api branch June 30, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants