-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate architecture SVG via API #304
Generate architecture SVG via API #304
Conversation
Preview: https://packit-dashboard-pr-304.surge.sh (deployed at Fri 30 Jun 2023, 15:16 UTC) |
Build succeeded. ✔️ pre-commit SUCCESS in 1m 38s |
Signed-off-by: Frantisek Lachman <[email protected]>
Signed-off-by: Frantisek Lachman <[email protected]>
1b163d1
to
db444a1
Compare
Build succeeded. ✔️ pre-commit SUCCESS in 1m 33s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the worker v. service remark, LGTM
def architecture_diagram(): | ||
system_info = make_response(f"{API_URL}/system").json | ||
system_info["packit_dashboard"] = dict(commit=os.environ.get("VITE_GIT_SHA")) | ||
system_info["packit_worker"] = system_info["packit_service"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure about this? 🤔 I don't think they're the same
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've discussed this locally. Currently, service and workers share repo and are built together so it's fine to expect this.
Build succeeded (gate pipeline). ✔️ pre-commit SUCCESS in 1m 43s |
Pull request merge failed: Merge commits are not allowed on this repository. |
This is to be able to generate an SVG file with architecture with the URLs using actual, deployed git hashes.