-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ORT to the list of adopters #350
Conversation
Make this list a bit more compact and readable. Signed-off-by: Sebastian Schuberth <[email protected]>
Do not imply importance by order. Signed-off-by: Sebastian Schuberth <[email protected]>
Signed-off-by: Sebastian Schuberth <[email protected]>
this PR mixes multiple scopes in one PR:
Some changes may be easy to adopt, others are debatable. Please create a dedicated PR for each scoped change, @sschuberth. I will close this PR without merging. |
Pull request was closed
True, but it nicely separates these (tiny) scopes into separate commits.
Seems like overkill to me for such trivial changes. But if you really feel like these trivial changes are each debatable on their own, I'll create individual PRs.
Honestly, I think that's a bit harsh without having written out contribution guidelines for this repository. I could have as well adapted this PR by rewriting commit history, which would have been my preferred approach. |
Here you go for now:
The other change makes only sense as-is after these (or at least the latter) is merged. |
I totally understand you, @sschuberth . My reasoning is: |
See #354. |
Please have a look at the individual commit messages for the details.