Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ORT to the list of adopters #350

Closed
wants to merge 3 commits into from
Closed

Add ORT to the list of adopters #350

wants to merge 3 commits into from

Conversation

sschuberth
Copy link
Member

Please have a look at the individual commit messages for the details.

Make this list a bit more compact and readable.

Signed-off-by: Sebastian Schuberth <[email protected]>
Do not imply importance by order.

Signed-off-by: Sebastian Schuberth <[email protected]>
Signed-off-by: Sebastian Schuberth <[email protected]>
@jkowalleck
Copy link
Member

this PR mixes multiple scopes in one PR:

  • reformat/alter the "Known implementations" section
  • reformat/alter the "Users, adopters and links" section
  • add something to the "Users, adopters and links" section.

Some changes may be easy to adopt, others are debatable.

Please create a dedicated PR for each scoped change, @sschuberth.
Thank you in advance.

I will close this PR without merging.

@jkowalleck jkowalleck closed this Nov 22, 2024
auto-merge was automatically disabled November 22, 2024 10:16

Pull request was closed

@sschuberth
Copy link
Member Author

this PR mixes multiple scopes in one PR:

True, but it nicely separates these (tiny) scopes into separate commits.

Please create a dedicated PR for each scoped change, @sschuberth.

Seems like overkill to me for such trivial changes. But if you really feel like these trivial changes are each debatable on their own, I'll create individual PRs.

I will close this PR without merging.

Honestly, I think that's a bit harsh without having written out contribution guidelines for this repository. I could have as well adapted this PR by rewriting commit history, which would have been my preferred approach.

@sschuberth sschuberth deleted the add-ort branch November 22, 2024 10:26
@sschuberth
Copy link
Member Author

I'll create individual PRs.

Here you go for now:

The other change makes only sense as-is after these (or at least the latter) is merged.

@jkowalleck
Copy link
Member

jkowalleck commented Nov 22, 2024

I totally understand you, @sschuberth .

My reasoning is:
there are a lot of unmerged PRs here, for the sole reason that they require communication, back and forth, and such.
I wanted to have your changes moving faster that the usual PRs here, since they all made a lot of sense to me. People would probably find it hard to review or would nitpick here and there - which would have as slowed reviews down. Individual changes as separate PRs - they may move with individual speed, and one does not block the other.

@sschuberth
Copy link
Member Author

The other change makes only sense as-is after these (or at least the latter) is merged.

See #354.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants