Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apk: define arch=source qualifier #312

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

apk: define arch=source qualifier #312

wants to merge 1 commit into from

Conversation

gernot-h
Copy link
Contributor

This proposes a similar approach for Alpine to what we agreed on for Debian in #57.

Thanks for reviewing, let me know what you think and if you need an additional issue for it!

@gernot-h
apk: define arch=source qualifier
9224ec9 
This is similar to what we agreed on for Debian in package-url#57.
@gernot-h
Copy link
Contributor Author

@Foxboron, as you contributed apk, I would also be interested in your opinion.

@Foxboron
Copy link
Contributor

I've read the Debian discussion and I don't think I agree with lamby and would prefer having a src qualifier to go along with pkg, but considering this was decided in 2021 I don't think my opinion matters on this.

Generally I think overloading the arch field is a mistake that is making this spec complicated.

@gernot-h
Copy link
Contributor Author

gernot-h commented Jul 12, 2024 •
edited
Loading

Thanks, @Foxboron, for your opinion! Apart from the how we express this, you agree that it actually makes sense if we define a way to specify package sources and also use abuild srcpkg as reference, right?

@Foxboron
Copy link
Contributor

Apart from the how we express this, you agree that it actually makes sense if we define a way to specify package sources and also use abuild srcpkg as reference, right?

Yes

@jkowalleck jkowalleck added the PURL type definition Non-core definitions that describe and standardize PURL types label Oct 17, 2024
@gernot-h
Copy link
Contributor Author

Is there anything I can do to complete or improve this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oej oej oej approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
PURL qualifiers component PURL type definition Non-core definitions that describe and standardize PURL types
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gernot-h @Foxboron @oej @jkowalleck @johnmhoran