Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add renderLastLine method to overriding if it need #71

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thykos
Copy link

@thykos thykos commented Oct 17, 2017

I use this component to truncating a text, and I need to use react-linkify inside. I can override renderLine for this goals, but I noticed that last line rendered with broken link, because of slicing text.

@moubi
Copy link
Contributor

moubi commented Aug 10, 2018

@thykos does the change with renderLastLine actually make any functional difference?

@thykos
Copy link
Author

thykos commented Nov 1, 2018

@thykos does the change with renderLastLine actually make any functional difference?

yes, if we use linkify and last line include link, link will be cutted and broken. With renredLastLine we can prevent broke

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants