Log a thrown error's status when available #5
Conversation
|
Nice! I saw the errors (with and without status) got formatted differently, I'd like to look into why that happened. |
| }; | ||
|
|
||
| const next = () => { | ||
| const error = new Error('GatewayTimeout'); |
There was a problem hiding this comment.
I would have expected at least that "GatewayTimeout" also got logged.
There was a problem hiding this comment.
ctx.throw formats the error message as such. with an actual koa app, I had this in the logs:
──‣ ┈┈┈┈┈ GET┈ ┬ /
╎ ServiceUnavailableError: Yo
╎ at Object.throw (node_modules/koa/lib/context.js:91:23)
╎ at app.use (server.js:44:22)
╎ at dispatch (node_modules/koa-compose/index.js:44:32)
╎ at next (node_modules/koa-compose/index.js:45:18)
╎ at logger (/home/jmu/Projects/concurrency-logger/src/index.js:323:19)
╎ at dispatch (node_modules/koa-compose/index.js:44:32)
╎ at next (node_modules/koa-compose/index.js:45:18)
╎ at app.use (server.js:8:11)
╎ at dispatch (node_modules/koa-compose/index.js:44:32)
╎ at node_modules/koa-compose/index.js:36:12
503 ┈┈1ms GET┈ ┴ /
In this case Yo was my custom error message. Maybe I should put that into the fake error stack?
There was a problem hiding this comment.
Looks like the formatting is different only because of overwriting .stack in the test cases. We need to make sure that it produces the same output for all environments, though.
Edit: I'm referring to the brackets vs no brackets around the log
There was a problem hiding this comment.
Your custom error class is something like class ServiceUnavailableError extends Error {}?
There was a problem hiding this comment.
We need to make sure that it produces the same output for all environments
Yeah I figured that's why the stack was overwritten. I'm not sure either why the new one has the curly brackets..
It's not a custom error, I'm using this to throw the error:
app.use(async context => {
context.throw(503, 'Yo');
});Then koa prepends the error message with 'ServiceUnavailableError: '. Also note that with the actual error (in the comment above), the error doesn't have curly brackets. Making it all the more puzzing :)
There was a problem hiding this comment.
Ha. Found it:
> var util = require('util')
undefined
> var err = new Error()
undefined
> err.stack = 'Err\n stack'
'Err\n stack'
> util.inspect(err)
'Err\n stack'
> err.status = 504
504
> util.inspect(err)
'{ Err\n stack status: 504 }'
> There was a problem hiding this comment.
So this is the culprit
There was a problem hiding this comment.
Maybe that even makes sense, when you attach some custom properties to an error.
But why didn't it print the brackets (with status inside) in the log you pasted?
An option would be if (arg instanceof Error) and roll our own pretty printing. I would be happy if it would work without needing to maintain that, though.
From the koa docs, when an error is thrown using
ctx.throwit may contain an status code. It would be nice to have that in the logs