-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove supress warnings #63
base: main
Are you sure you want to change the base?
Conversation
Hey! Is there a way to silence this warnings now? This was added due to many complaints about the "unused prop" warnings. The console can be flooded by these. |
@pablo-abc It is not wise to clear Svelte warnings. What if you miss a warning that helps you to fix a bug? I recommend that you keep it as is. You can always enable/disable warnings in browser console. |
Second the change. Silently modifying globals is a sure way to cause a lot of pain. If it helps, all modern consoles have filters that can be used to tune out unwanted logs. |
@aryzing Maintainer seems unresponsive. So, i have created and published fixed version to npm. See my comment here: |
Thank you @dogagenc. I'll take a look at your fork. Fyi @pablo-abc, if you've got too much on your plate now, you may want to consider adding contributors to this repo. Seems that if this repo doesn't receive more attention, more forks may start to take off. Given this repo's popularity, seems we would best served by capturing further improvements here. |
@pablo-abc
|
FYI I opened a PR which is a bit less drastic than just suppressing all the warnings (which are truly annoying). |
The code line
console.warn = ...
is causing an error in Firefox that interrupts the program's execution. In addition, I believe that it is not advisable to silence warnings from the framework or UI library when they are used as a sub-package.