Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented mising blending filters #102

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Shiwank19
Copy link

I have researched missing blending filter formulae and implemented them.Please have a look.

@abhikpal
Copy link
Member

The code looks okay to me. But before I test things out, I have comments:

  1. Could you do a merge request against the develop branch?
  2. It would be nice to have some examples to go with the code. Add them here: (https://github.com/p5py/p5-examples). I usually use the following convention with examples:
    1. if it's from the examples section from Processing (Java) (https://processing.org/examples/) then it goes in the folder with the appropriate section name (so basics/math/additive_wave.py is a port of https://processing.org/examples/additivewave.html)
    2. If it's from the reference section, it goes in the reference folder (with a similar folder structure as (i))

@Shiwank19
Copy link
Author

ok I am working on both the points you mentioned.
Sir My code is related to image directory inside examples.I am going to add examples for each blend mode.

@Shiwank19
Copy link
Author

I have made pull request to develop branch of p5py and also added new examples for each blending mode I've implemented.I have created a pull request to develop branch of p5-examples.
Please review it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants