Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use franz-go in kafka plugin #646

Merged
merged 7 commits into from
Jul 19, 2024
Merged

use franz-go in kafka plugin #646

merged 7 commits into from
Jul 19, 2024

Conversation

DmitryRomanov
Copy link
Collaborator

@DmitryRomanov DmitryRomanov commented Jun 25, 2024

Use franz-go for kafka output and input plugins

  • add some options for input kafka (heartbeat,session,AWS_MSK_IAM sasl mechanism,auto_commit_interval,balancer_plan,max_concurrent_fetches,fetch_max_bytes,fetch_min_bytes)
  • add some options for output kafka (compression,ack)
  • remove of using sarama
  • fix flaky split_join e2e test

@DmitryRomanov DmitryRomanov force-pushed the kafka-franz-go branch 14 times, most recently from c959491 to 5922273 Compare June 27, 2024 10:12
@DmitryRomanov DmitryRomanov changed the title use franz-go in kafka input plugin use franz-go in kafka plugin Jun 27, 2024
@DmitryRomanov DmitryRomanov force-pushed the kafka-franz-go branch 7 times, most recently from 4a28d31 to 0699ad4 Compare July 2, 2024 05:07
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

Attention: Patch coverage is 78.71622% with 63 lines in your changes missing coverage. Please review.

Project coverage is 71.25%. Comparing base (67ecc39) to head (130dbeb).
Report is 21 commits behind head on master.

Files Patch % Lines
cfg/kafka_client.go 58.46% 23 Missing and 4 partials ⚠️
plugin/output/kafka/client.go 59.45% 14 Missing and 1 partial ⚠️
plugin/input/kafka/client.go 78.04% 8 Missing and 1 partial ⚠️
plugin/output/kafka/kafka.go 83.87% 4 Missing and 1 partial ⚠️
plugin/input/kafka/kafka.go 93.22% 3 Missing and 1 partial ⚠️
e2e/kafka_file/kafka_file.go 88.23% 1 Missing and 1 partial ⚠️
e2e/split_join/split_join.go 96.96% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #646      +/-   ##
==========================================
+ Coverage   70.83%   71.25%   +0.41%     
==========================================
  Files         124      132       +8     
  Lines       12572    13116     +544     
==========================================
+ Hits         8906     9346     +440     
- Misses       3150     3235      +85     
- Partials      516      535      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DmitryRomanov DmitryRomanov marked this pull request as ready for review July 2, 2024 10:34
@DmitryRomanov DmitryRomanov force-pushed the kafka-franz-go branch 2 times, most recently from 36de039 to 130dbeb Compare July 4, 2024 07:07
cfg/kafka_client.go Outdated Show resolved Hide resolved
@DmitryRomanov DmitryRomanov merged commit b7f14f5 into master Jul 19, 2024
8 checks passed
@DmitryRomanov DmitryRomanov deleted the kafka-franz-go branch July 19, 2024 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants