Add more checks to timeseries schema #6009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
bnaecker
commented
Jul 6, 2024
bnaecker
commented
- Add checks for the length of all field names, timeseries names, and descriptions. All must be non-empty, and below some const limit. Add tests for these as well.
- Add extra derives to generated target / metric types. Where possible, derive Copy, Eq, PartialOrd, Ord, and Hash, based on the types in the definitions (e.g., strings mean the type cannot be copy).
- Add checks for the length of all field names, timeseries names, and descriptions. All must be non-empty, and below some const limit. Add tests for these as well. - Add extra derives to generated target / metric types. Where possible, derive Copy, Eq, PartialOrd, Ord, and Hash, based on the types in the definitions (e.g., strings mean the type cannot be copy).
bnaecker
force-pushed
the
check-timeseries-schema-field-lengths
branch
from
9a1a096
to
2c68d88
Compare
smklein
approved these changes
Jul 8, 2024
Exhaustively match against `FieldType` to determine if it's copyable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.