Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(linter): add rule no-undefined #4041

Merged

Conversation

jordan-boyer
Copy link
Contributor

Implementing rule https://eslint.org/docs/latest/rules/no-undefined

This is my first time contributing here, I wanted to started with a simple rule before contributing more.

related to #479

Copy link

graphite-app bot commented Jul 3, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the A-linter Area - Linter label Jul 3, 2024
Copy link

codspeed-hq bot commented Jul 3, 2024

CodSpeed Performance Report

Merging #4041 will not alter performance

Comparing jordan-boyer:add-eslint-core-no-undefined (864efe0) with main (38e7351)

Summary

✅ 28 untouched benchmarks

@mysteryven
Copy link
Member

Thanks for your contribution! You can fix the CI by run just ready in your local.

@DonIsaac
Copy link
Collaborator

DonIsaac commented Jul 4, 2024

LGTM

@DonIsaac DonIsaac merged commit 6876490 into oxc-project:main Jul 5, 2024
25 checks passed
@jordan-boyer jordan-boyer deleted the add-eslint-core-no-undefined branch July 5, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants