fix(isolated_declarations): Fix readonly specifier on class constructor params

[escaton]

No description provided.

[graphite-app]

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

[escaton]

@Dunqing Here is one more :)

[Dunqing]

I compared our output with the typescript's output and the result is still incorrect. But we can fix this in another PR

https://www.typescriptlang.org/play/?noCheck=false&isolatedDeclarations=true&isolatedModules=true#code/KYDwDg9gTgLgBAYwDYEMDOa4CEITgbwCg5EIA7NGKAVwRmgAoxqAjJASwTimBQBNySAJ5wwUCGABccMtQC2LYFDgBeOAAYANN14Cyw0eLAAmabIVLVcAIwBKAgF9CDoA

[escaton]

You are right, I missed that. If you have an idea where is the problem, I'm happy to fix it in this PR

[codspeed-hq]

CodSpeed Performance Report

Merging #4030 will not alter performance

_{Comparing escaton:fixes-3 (c233c31) with main (da62839)}

Summary

✅ 28 untouched benchmarks

[Dunqing]

You are right, I missed that. If you have an idea where is the problem, I'm happy to fix it in this PR

We need to replace this with if param.accessibility.is_some() || param.readonly {

oxc/crates/oxc_isolated_declarations/src/class.rs

Line 234 in 78c66d3

if param.accessibility.is_some() {

[escaton]

Done.
There is still a little difference: TSC emits no type for private prop2
Oxc:

export declare class Boo {
	readonly prop: number;
	private readonly prop2: number;
	readonly prop3: number;
	constructor(prop?: number, prop2?: number, prop3?: number);
}

TSC:

export declare class Boo {
    readonly prop: number;
    private readonly prop2;
    readonly prop3: number;
    constructor(prop?: number, prop2?: number, prop3?: number);
}

But I don't think it is critical. Let me create a separate issue for that.
#4033

[Dunqing]

Thank you!