Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(semantic): copy tests from typescript-eslint’s scope-manager #3990

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Jul 1, 2024

close: #2947

These fixtures were copied from https://github.com/typescript-eslint/typescript-eslint/tree/a5b652da1ebb09ecbca8f4b032bf05ebc0e03dc9/packages/scope-manager/tests/fixtures. We used them to test out semantic ScopeTree and SymbolTable

Copy link

graphite-app bot commented Jul 1, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

Dunqing commented Jul 1, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Dunqing and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added the A-semantic Area - Semantic label Jul 1, 2024
@Dunqing Dunqing force-pushed the 07-01-chore_semantic_copy_tests_from_typescript-eslint_s_scope-manager branch 2 times, most recently from 1ec7652 to 3b78811 Compare July 1, 2024 07:28
Copy link

codspeed-hq bot commented Jul 1, 2024

CodSpeed Performance Report

Merging #3990 will not alter performance

Comparing 07-01-chore_semantic_copy_tests_from_typescript-eslint_s_scope-manager (4debcf3) with main (0b56d50)

Summary

✅ 28 untouched benchmarks

@Dunqing Dunqing force-pushed the 07-01-chore_semantic_copy_tests_from_typescript-eslint_s_scope-manager branch 4 times, most recently from 52a4da3 to 1310c54 Compare July 1, 2024 09:58
@Dunqing Dunqing force-pushed the 07-01-chore_semantic_copy_tests_from_typescript-eslint_s_scope-manager branch from 1310c54 to 4debcf3 Compare July 1, 2024 10:05
@Dunqing
Copy link
Member Author

Dunqing commented Jul 1, 2024

It's kind of weird that the fields in my local and CI's snap are in a different order. So, I had to tweak the order of the different fields in push_str to make CI pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-semantic Area - Semantic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Robust testing for scope analysis
1 participant