-
-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flake templates #188
base: master
Are you sure you want to change the base?
Flake templates #188
Conversation
I personally cannot get the point of flake template until it gets anything more than a fancier
I prefer adding more examples if user want something for reference, than flake templates for directly |
Nix's templates are somewhat limited in what they can provide due to a lack of granularity. There has been some ideation, but its mostly a dead end. I agree that Crane is probably the best option for most users to setup shells alongside packaging. Sorry that I can't really provide a satisfying answer. |
in | ||
devShells.default = mkShell { | ||
buildInputs = with pkgs; [ | ||
rust-bin.stable.latest.default |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For a dev shell, wouldnt it be useful to also include rust-analyzer and rust-src?
- rust-bin.stable.latest.default
+ (rust-bin.stable.latest.default.override {
+ extensions = [ "rust-analyzer" "rust-src" ];
+ })
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unsure on this one. How useful this would be to users depends on how they have their IDE and system configured. On NixOS this might make more sense. For users on other distributions which use Nix for a specific project, they may have their language servers installed globally (e.g. system package manager, rustup
) or by their editor (e.g. VSCode extensions, mason.nvim) which may not pickup an LS in the local environment. Worth including in further discussions about what templates for rust-overlay should be/include.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's fair, though I'm not sure what the point of a rust devShell would be if rust is already installed globally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many people prefer using/creating dev shells for open source stuff to lower the barrier of entry to hacking on the project, by removing the need to globally install tools and preventing the dreaded "It works on my machine" problem. They also help ensure the same (versions of) tools are used in development, CI and packaging. Dev shells are still useful for personal projects for these reasons, but their true potential shines when used by multiple people or across many machines.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know what the point of a devShell is 😅 My point was that a devShell isn't needed if rust is already installed globally, especially with rust having almost perfect backwards compatibility (even more so on stable releases as is the case here). This is also a devShell, it doesn't build a package or anything.
I'd agree with you if this was a non-trivial devShell that includes dependencies (eg. pkg-config, openssl, some specific dev tooling, a specific version of the rust toolchain), but this is just a template where people can build upon. People can remove the extensions they don't need after creating it, and it also serves as an example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but this is just a template where people can build upon. People can remove the extensions they don't need after creating it,
No they wouldn't. Most of people will copy code from internet, check if it compiles(evals), and then keep it forever without a second glance. ChatGPT hype and sshd-depends-on-systemd (JiaTan's supply chain attack) all taught us that. I'm against making a "template" too big and/or too complete.
In response to issue #119.
Adds a new example to the
examples
folder that provides a flake with a dev shell with the default stable toolchain and allows use on multiple systems via flake utils. Based on this README example.Template can be initialised with:
I'm considering creating another template that uses a
rust-toolchain.toml
instead, but I will save that for another pull request.