Formatted networkPolicy to match feature documentation template #4467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
kind/documentation
npinaeva
reviewed
Jul 1, 2024
github-actions
bot
added
feature/egress-ip
dtzhou2
force-pushed
the
NetworkPolicy
branch
2 times, most recently
from
78e13ae
to
6ecd30b
Compare
|
Resolved reviewer suggestions,changed wording to make documentation more clear |
npinaeva
reviewed
Jul 15, 2024
| [Kubernetes NetworkPolicy documentation](https://kubernetes.io/docs/concepts/services-networking/network-policies) | ||
|
|
||
| [Kubernetes NetworkPolicy API reference](https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.19/#networkpolicy-v1-networking-k8s-io) | ||
|
|
||
| By default, the network traffic from and to K8s pods is not restricted in any way. Using NetworkPolicy is a way to enforce network isolation of selected pods. When a pod is selected by a NetworkPolicy allowed traffic is specified by the `Ingress` and `Egress` sections. | ||
| Network Policy is a resource, which helps enforce the network isolation of pods. By default, the network traffic from and to K8s pods are not restricted in any way: NetworkPolicy resources allow us to enable and/or disable specific dataflows at a pod level. |
There was a problem hiding this comment.
I think the current version is more accurate, can we just leave it as is?
|
|
||
| ## **Unicast default-deny** | ||
| Feature is always enabled and triggered upon creation of NetworkPolicy objects. |
There was a problem hiding this comment.
There is a config flag for this, look for EnableAdminNetworkPolicy
There was a problem hiding this comment.
From my understand AdminNetworkPolicy and NetworkPolicy were seperate objects but I may have read the documentation incorrectly
Signed-off-by: Daniel Zhou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does and why is it needed
Reformatted networkPolicy to match feature documentation template. Added more examples detailing different types of networkPolicies. Reworded certain sections to make more documentation more clear and easy to read.
Which issue(s) this PR fixes
Fixes #
Special notes for reviewers
How to verify it
Details to documentation updates
Reformatted networkPolicy to match feature documentation template. Added more examples detailing different types of networkPolicies. Reworded certain sections to make more documentation more clear and easy to read.
Description for the changelog
Does this PR introduce a user-facing change?