-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better support for unserializable props in fixture #15
Conversation
@w0rm can you please take a look? It's a generic fix for react-cosmos/react-cosmos#130 and other use cases when fixture props aren't serializable (state should always be). This is how I test Cosmos with a WIP ComponentPlayground branch: #14 (comment) I'm not very happy with the ad-hoc |
Looks fine to me. However I'm on vacations now and not able to try this out on a working project. |
No worries. Do you know when you'll be able to try it out? I can wait to make sure it covers your use case. Enjoy your vacation! |
My vacation is until the 9th of June.
|
Conflicts: tests/components/component-playground/children.js tests/components/component-playground/events.js tests/components/component-playground/state.js
Old tests missed this
Conflicts: tests/components/component-playground/children.js tests/components/component-playground/events.js tests/components/component-playground/state.js
Was destroying unserializable members
Figured out some things were wrong on this branch so I started a brand new PR: #18 |
state.fixtureUnserializableProps
statics.getFixtureState
, faster than on every editor change (onFixtureState
)CustomdeepEqual(prop, parse(stringify(prop))
to determine unserializable propsisSerializable
helper