Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the concept of "validation_mode" #1185

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

joesaunderson
Copy link
Contributor

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Documented? yes
Fixed tickets N/A
License MIT

Adds the concept of validation_mode at the default config level.

@Vincz
Copy link
Collaborator

Vincz commented May 17, 2024

Excellent @joesaunderson! You are on the right track! Do you think it would be possible to also be able to manage the validation mode on the object itself (if it's too complicated, we'll try to implement in a future release).
If you can also add the test (with the same object applying both modes and validate the output).

@TomasLudvik
Copy link

Hello @joesaunderson and @Vincz , is it possible to move his PR forward as it solves problem introduced in #1184 ? We are locked on version 1.3.2 and are waiting for this to be fixed. Thank you.

@joesaunderson
Copy link
Contributor Author

I won't have the time I'm afraid, but someone can take this base and make the changes @Vincz suggests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants