create zig.exe symlink on every download-zig.sh execution #8568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Symlink is not created on first setup.
vinnichase
changed the title
|
thanks |
ryoppippi
pushed a commit
to ryoppippi/bun
that referenced
this pull request
Feb 1, 2024
Symlink is not created on first setup.
sroussey
pushed a commit
to sroussey/bun
that referenced
this pull request
Feb 2, 2024
Symlink is not created on first setup.
Hanaasagi
pushed a commit
to Hanaasagi/bun
that referenced
this pull request
Feb 3, 2024
Symlink is not created on first setup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symlink is not created on first setup.
see ziglang/vscode-zig#164
and #8147
What does this PR do?
Moved the symlink creation out of the if statement to ensure it will be run on first clone and on subsequent updates of zig.
How did you verify your code works?
Ran the script with empty
.cachefolder and again with zig already installed.zig.exeis present.