heavy revision on heap_breakdown's safety #12445
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
I wish we had some internal docs on heap breakdown. It is very cool. This PR makes it more safe for us to use.
Rename
bun.HeapBreakdown
tobun.heap_breakdown
. Renamebun.is_heap_breakdown_enabled
tobun.heap_breakdown.enabled
.To use the heap breakdown allocator functions directly, recommend using
heap_breakdown.getZone(T).create(T, t)
. But it is better to simply use thebun.New
mixin, which opts you into heap breakdown automatically.Refactors the following:
bun.new
,bun.destroy
,bun.create
,bun.New
,bun.NewRefCounted
. They are much easier to read now.Main motivation for this is to introduce a new assertion which ensures types that forcefully opt into heap breakdown (From
bun.New
) are impossible to create via standard library allocators.