Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle OOM in btoa #12353

Merged
merged 2 commits into from
Jul 6, 2024
Merged

Handle OOM in btoa #12353

merged 2 commits into from
Jul 6, 2024
+14 −10

Conversation

Jarred-Sumner
Copy link
Collaborator

What does this PR do?

Handle OOM in btoa

I don't think this actually happens, but we check nonetheless

How did you verify your code works?

@Jarred-Sumner Jarred-Sumner requested review from a team, dylan-conway and paperdave and removed request for a team and dylan-conway July 5, 2024 06:06
paperdave
paperdave approved these changes Jul 6, 2024
View reviewed changes
Copy link
Collaborator

@paperdave paperdave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is better than nothing so approved, however Bun__encoding__toString( does not seem to handle OOM

@Jarred-Sumner Jarred-Sumner merged commit cd97c21 into main Jul 6, 2024
@Jarred-Sumner Jarred-Sumner deleted the jarred/handle-oom branch July 6, 2024 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paperdave paperdave paperdave approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Jarred-Sumner @paperdave